Unset start time for ordered consumer on retry #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an ordered consumer was configured with a start time, on retry, the copied consumer config would start with sequence but the existing start time opt would conflict causing a config error. Fix #1281 Signed-off-by: Byron Ruth <byron@nats.io>
Merged
piotrpio
pushed a commit
that referenced
this pull request
Aug 22, 2023
If an ordered consumer was configured with a start time, on retry, the copied consumer config would start with sequence but the existing start time opt would conflict causing a config error. Fix #1281 Signed-off-by: Byron Ruth <byron@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ordered consumer was configured with a start time, on retry, the copied consumer config would start with sequence but the existing start time opt would conflict causing a config error.
Fix #1281
Just noting that I added the
StartTime()opt to the test which, without clearing start time on retry (the fix), it will demonstrate the behavior and get this message: