Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Invalid heartbeat errors in Consume() #1345

Merged
merged 1 commit into from
Jul 15, 2023
Merged

[FIXED] Invalid heartbeat errors in Consume() #1345

merged 1 commit into from
Jul 15, 2023

Conversation

piotrpio
Copy link
Collaborator

Resolves #1343

@piotrpio
[FIXED] Invalid heartbeat errors in Consume()
2ab2858 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from Jarema July 13, 2023 11:48
Jarema
Jarema approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit c213303 into main Jul 15, 2023
1 of 2 checks passed
@piotrpio piotrpio deleted the pause-heartbeat branch July 15, 2023 21:57
@mdawar mdawar mentioned this pull request Jul 16, 2023
Closed
@piotrpio piotrpio mentioned this pull request Jul 20, 2023
Merged
piotrpio added a commit that referenced this pull request Aug 22, 2023
@piotrpio
[FIXED] Invalid heartbeat errors in Consume() (#1345)
35ba596 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New JetStream API: calling Stop() makes Next() block indefinitely or until a missing heartbeat error
2 participants
@piotrpio @Jarema