[IMPROVED] Fixed flaky tests in js.Subscribe() and kv #1374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 frequent flaky tests:
TestJetStreamSubscribe_AckPolicy()
- in this testsub.Drain()
was executed before getting consumer info. Even thoughnats.Durable()
option was used inSubscribe()
, the consumer is still deleted if created by libraryTestKeyValueMirrorCrossDomains()
- there were races in this test and it sometimes failed if values were not propagated to the mirror before attempting to get them