[ADDED] Setting heartbeats in Fetch and FetchBatch in legacy API #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Jarema
requested changes
Sep 15, 2023
| @@ -2813,15 +2831,36 @@ func (sub *Subscription) Fetch(batch int, opts ...PullOpt) ([]*Msg, error) { | |||
| nr.Expires = expires | |||
| nr.NoWait = noWait | |||
| nr.MaxBytes = o.maxBytes | |||
| if 2*o.hb < expires { | |||
There was a problem hiding this comment.
If heartbeat is larger than expires/2, server will return first message as error:
400, Some(\"Bad Request - heartbeat value too large\")") }
So I would rather not have that logic here and allow server to throw that error normally?
There was a problem hiding this comment.
Unfortunately this is required because Fetch can send more than 1 pull request, and even though for the first request the value may be valid, when the second one is sent we don't really know up front what the expiry will be - so if we depend on the server we will return an error when we shouldn't.
There was a problem hiding this comment.
Hm. Maybe return error when users tries to send fetch with bad hb?
piotrpio
force-pushed
the
legacy-fetch-hb
branch
from
06ef32d
to
a7cd4ea
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.