[FIXED] Stream create response test for sources being present in the response. #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponse. Server 2.10 now returns source infos (as well as the config) so you can for example tell which sources where successfully added for the stream, and what their current state is) but 2.9 would only return the source config info inside the stream info. nats.go 2.10 added a check that all of the sources defined in the config where indeed added to the stream in the stream create transform, which would work with a 2.10 server but not with a 2.9. This fixes the test by downgrading it to the best you can do with a 2.9 server which is check against the stream config returned in the create response message. Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server 2.10 now returns source infos (as well as the config) so you can for example tell which sources where successfully added for the stream, and what their current state is) but 2.9 would only return the source config info inside the stream info.
nats.go 2.10 added a check that all of the sources defined in the config where indeed added to the stream in the stream create transform, which would work with a 2.10 server but not with a 2.9.
This fixes the test by downgrading it to the best you can do with a 2.9 server which is check against the stream config returned in the create response message.