Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client dependencies list #1439

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update client dependencies list #1439

merged 1 commit into from
Oct 12, 2023

Conversation

piotrpio
Copy link
Collaborator

Signed-off-by: Piotr Piotrowski piotr@synadia.com

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is goleak? This for testing only?

@piotrpio
Copy link
Collaborator Author

piotrpio commented Oct 12, 2023

@derekcollison Yes, only for testing. It helped us discover some leaking goroutines.

It runs after each test and checks if no goroutines were left unclosed.

@piotrpio piotrpio merged commit e76c644 into main Oct 12, 2023
2 checks passed
@piotrpio piotrpio deleted the update-dependencies branch October 12, 2023 18:58
@piotrpio piotrpio mentioned this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants