Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Domain to js.AccountInfo() response #753

Merged
merged 2 commits into from Jun 19, 2021
Merged

Add Domain to js.AccountInfo() response #753

merged 2 commits into from Jun 19, 2021

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jun 17, 2021

Also includes test for #750.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs
Copy link
Member Author

wallyqs commented Jun 18, 2021

Merging after fixing the following in the server to prevent breaking the build: nats-io/nats-server#2290

@derekcollison
Copy link
Member

Fixed

@wallyqs wallyqs force-pushed the js-domains branch 2 times, most recently from c53aea7 to 79d5110 Compare June 18, 2021 22:58
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 86.792% when pulling f26359c on js-domains into e4b051a on master.

@wallyqs wallyqs merged commit cc4f3b2 into master Jun 19, 2021
@wallyqs wallyqs deleted the js-domains branch June 19, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants