Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxMsgsPerSubject to StreamConfig #768

Merged
merged 1 commit into from Jul 1, 2021
Merged

Add MaxMsgsPerSubject to StreamConfig #768

merged 1 commit into from Jul 1, 2021

Conversation

variadico
Copy link
Contributor

This adds MaxMsgsPerSubject to StreamConfig and adds a test to verify the behavior.

Closes #749

@variadico variadico requested a review from wallyqs June 30, 2021 18:02
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.816% when pulling c8db2d3 on max-msgs-subj into 274aa57 on master.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit c7fc3c7 into master Jul 1, 2021
@variadico variadico deleted the max-msgs-subj branch July 1, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js: Add nats.MaxMsgsPerSubject option
5 participants