Reworked PullSubscribe implementation #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a SyncSubscription instead. The only visible change from the user is that calling Fetch() after Unsubscribe() returns ErrBadSubscription instead of timeout or context deadline exceeded, which makes more sense to me. This is the only test that I had to tweak. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
commented
Aug 10, 2021
| @@ -1433,7 +1337,7 @@ func (sub *Subscription) resetOrderedConsumer(sseq uint64) { | |||
| osid := sub.applyNewSID() | |||
|
|
|||
| // Grab new inbox. | |||
| newDeliver := NewInbox() | |||
| newDeliver := nc.newInbox() | |||
There was a problem hiding this comment.
@derekcollison Unrelated to this PR, but while I was changing references to NewInbox() in subscribe, I found this one and changed it too. If it should not be changed, let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a SyncSubscription instead. The only visible change from the
user is that calling Fetch() after Unsubscribe() returns ErrBadSubscription
instead of timeout or context deadline exceeded, which makes more
sense to me. This is the only test that I had to tweak.
Signed-off-by: Ivan Kozlovic ivan@synadia.com