Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where JS would change subscription subject #793

Merged
merged 1 commit into from Aug 13, 2021
Merged

Fixed issue where JS would change subscription subject #793

merged 1 commit into from Aug 13, 2021

Conversation

kozlovic
Copy link
Member

This would cause issues during a reconnect

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic
Fixed issue where JS would change subscription subject
c91c104 
This would cause issues during a reconnect

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 87.084% when pulling c91c104 on fix_subject_rewrite into d1955c8 on master.

derekcollison
derekcollison approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 9c00d13 into master Aug 13, 2021
@kozlovic kozlovic deleted the fix_subject_rewrite branch August 13, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kozlovic @coveralls @derekcollison