Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Stringer for connection status #812

Merged

Conversation

josephwoodward
Copy link
Contributor

@josephwoodward josephwoodward commented Sep 2, 2021

This change updates the connection status by implementing the Stringer interface, enabling users to log out the connection status in a human readable format.

I've updated an existing tests to verify the string output. It's not exhaustive, but covers the same cases the existing test exercises. If you'd rather I add a separate test that covers each permutation then let me know and I can update the pull request.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/conn_test.go Outdated Show resolved Hide resolved
@josephwoodward
Copy link
Contributor Author

Updated the test to use String() in instead of fmt.Sprintf(...) to satisfy the linter.

@kozlovic kozlovic changed the title Implement Stringer for connection status [ADDED] Stringer for connection status Sep 2, 2021
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants