Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Websocket: possible panic when decoding CLOSE frame #821

Merged
merged 2 commits into from Sep 13, 2021

Conversation

kozlovic
Copy link
Member

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - One small comment on readability.

ws.go Outdated Show resolved Hide resolved
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
ws.go Outdated Show resolved Hide resolved
@kozlovic
Copy link
Member Author

@derekcollison Did update and "push force" so that you can check against original code to see if it reads better. Happy to change again if not readable enough (once ok, I will apply the same changes to the server PR).

ws.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 13, 2021

Coverage Status

Coverage increased (+0.1%) to 87.296% when pulling 949abff on ws_fix_close_partial into eb89c8a on main.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 1714547 into main Sep 13, 2021
@kozlovic kozlovic deleted the ws_fix_close_partial branch September 13, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants