New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
js: unblock batch requests on 408 with at least a message #823
Conversation
120a7ad
to
703441c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing some changes...
test/js_test.go
Outdated
expected := "hello" | ||
got := string(msg.Data) | ||
if got != expected { | ||
t.Errorf("Expected: %v, got: %v", expected, got) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have t.Errorf()? Any error that we have is fatal, there is no point continuing the test I think.
If you agree, then this comment applies to all other references of t.Errorf() you have in this test.
a573b72
to
673391b
Compare
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
673391b
to
7669068
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This makes it so that fetch requests that receive a 408 message signal to be canceled become unblocked in case they have received a single message at least.
Signed-off-by: Waldemar Quevedo wally@synadia.com