[FIXED] Received JetStream message may have wrong subject #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent PR #824 tried to optimize reducing memory copy by using the non JS, non wildcard subscription's subject as the message subject. However, in case where a NATS subscription is used for the delivery subject of a AddConsumer call, then this breaks and the message would be received with the subscription subject instead of the subject that we get from MSG parsing. This PR basically reverts changes from #824 and add a subject to make sure that we catch such issue in the future. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent PR #824 tried to optimize reducing memory copy
by using the non JS, non wildcard subscription's subject
as the message subject.
However, in case where a NATS subscription is used for
the delivery subject of a AddConsumer call, then this
breaks and the message would be received with the subscription
subject instead of the subject that we get from MSG parsing.
This PR basically reverts changes from #824 and add a subject
to make sure that we catch such issue in the future.
Signed-off-by: Ivan Kozlovic ivan@synadia.com