Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] JetStream: queue name cannot contain "." when used as durable #841

Merged
merged 1 commit into from Oct 7, 2021

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Oct 7, 2021

When calling js.QueueSubscribe[Sync](subject, queue_name), if
no durable name is provided, the queue name is used as the durable
name, so the same restriction applies

Resolves #840

Signed-off-by: Ivan Kozlovic ivan@synadia.com

When calling `js.QueueSubscribe[Sync](subject, queue_name)`, if
no durable name is provided, the queue name is used as the durable
name, so the same restriction applies

Resolves #840

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 86.928% when pulling e30a745 on fix_840 into 6305227 on main.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 4e70dbe into main Oct 7, 2021
@kozlovic kozlovic deleted the fix_840 branch October 7, 2021 18:47
@joseph-woodward-form3
Copy link

@kozlovic Thank you for fixing this so quickly! Do you have any ideas on when the next client release is?

@ripienaar
Copy link
Contributor

@joseph-woodward-form3 there was one yesterday

@joseph-woodward-form3
Copy link

@ripienaar Oh wow, the NATS team/contributors don't about about do they! Thanks! 😁

@ripienaar
Copy link
Contributor

We aim to please :) hope that resolves it for you, do let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Durable field not being validated before being set from queue name
5 participants