Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Conditional delete and purge for KV #856

Merged
merged 1 commit into from Apr 7, 2022

Conversation

steveh
Copy link
Contributor

@steveh steveh commented Nov 4, 2021

I've been testing out the experimental KV functionality, and conditional delete and purge would be very useful to us.

It appears to work out of the box on the server too in my limited testing. If you're happy with the naming and implementation I will flesh out the tests more.

@coveralls
Copy link

coveralls commented Nov 4, 2021

Coverage Status

Coverage increased (+0.01%) to 85.201% when pulling 95a94e1 on steveh:conddeletepurge into e076b0d on nats-io:main.

@ripienaar
Copy link
Contributor

I like the idea but we need better function names I think, any suggestions @derekcollison ?

kv.go Outdated Show resolved Hide resolved
@derekcollison
Copy link
Member

I would add an option to those that takes a revision for the conditional delete vs adding new methods.

@steveh steveh force-pushed the conddeletepurge branch 2 times, most recently from 9a161ee to 622af90 Compare November 11, 2021 21:04
@steveh
Copy link
Contributor Author

steveh commented Nov 11, 2021

Updated to use options instead of additional functions.

kv.go Outdated Show resolved Hide resolved
@ripienaar ripienaar self-requested a review November 17, 2021 12:13
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit dd91b86 into nats-io:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants