Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More meaningful message when trying to ack message that was already acknowledged #857

Closed
Berreek opened this issue Nov 8, 2021 · 2 comments
Labels
feature New feature request

Comments

@Berreek
Copy link
Contributor

Berreek commented Nov 8, 2021

Feature Request

Currently when you ack the message that was already acknowledged you get following error:
nats: invalid jetstream publish response

Recently I got quite a lot of this in our application and it turned out that we performed double ack'ing since we did not have ManualAck option enabled. However we had to debug it trough to discover the root of this issue since it was not possible to understand it from the message above.

Proposed Change:

Change error message to something that will give you a actual context of the error. For example:
nats: message was already acknowledged

Don't mind doing a PR for it if you are fine with the change.

@Berreek Berreek added the feature New feature request label Nov 8, 2021
@wallyqs
Copy link
Member

wallyqs commented Nov 8, 2021

This sounds good to me, feel free to make the PR. Thanks.

@wallyqs
Copy link
Member

wallyqs commented Dec 2, 2021

Fixed via #862

@wallyqs wallyqs closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants