Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AddConsumer stream not found error #881

Merged
merged 1 commit into from Jan 12, 2022
Merged

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jan 12, 2022

Updates to return ErrStreamNotFound when using AddConsumer against a missing stream.
Signed-off-by: Waldemar Quevedo wally@synadia.com

Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 84.985% when pulling 690f3a4 on err-stream-not-found into a915f85 on main.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 4db0fb0 into main Jan 12, 2022
@wallyqs wallyqs deleted the err-stream-not-found branch January 12, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants