Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended comment for Subscribe method #886

Merged
merged 2 commits into from Jan 20, 2022
Merged

Extended comment for Subscribe method #886

merged 2 commits into from Jan 20, 2022

Conversation

ipromax
Copy link
Contributor

@ipromax ipromax commented Jan 20, 2022 •
edited

Currently, the comment for Subscribe method contains some unclear information about wildcards.

kozlovic
kozlovic requested changes Jan 20, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the meaning was to say: "partial: this is the * wildcard" and "full: this is the '>' wildcard".

@coveralls
Copy link

coveralls commented Jan 20, 2022 •
edited

Coverage Status

Coverage remained the same at 85.01% when pulling d2b3332 on ipromax:fix-comment into 4db0fb0 on nats-io:main.

@ipromax ipromax closed this Jan 20, 2022
@kozlovic
Copy link
Member

@ipromax I was not suggesting that you close the PR, we could make it more obvious of what the meaning was. If you got it wrong, some other users may get it wrong too.

@ipromax ipromax reopened this Jan 20, 2022
@ipromax ipromax changed the title Fixed comment for Subscribe method Extended comment for Subscribe method Jan 20, 2022
kozlovic
kozlovic approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 5702db7 into nats-io:main Jan 20, 2022
@ipromax ipromax deleted the fix-comment branch April 14, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ipromax @coveralls @kozlovic