Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] JetStream: Nak delay and BackOff lists #894

Merged
merged 3 commits into from Feb 1, 2022
Merged

[ADDED] JetStream: Nak delay and BackOff lists #894

merged 3 commits into from Feb 1, 2022

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Feb 1, 2022

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic
[ADDED] JetStream: Nak delay and BackOff lists
fd2a476 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
derekcollison reviewed Feb 1, 2022
View reviewed changes
test/js_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 1, 2022 •
edited

Coverage Status

Coverage increased (+0.4%) to 85.368% when pulling d34c12d on nak_with_delay_and_backoff into 565319f on main.

@kozlovic
Remove NakDelay() option and instead add Msg.NakWithDelay()
f1d50b8 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic
Copy link
Member Author

kozlovic commented Feb 1, 2022

@derekcollison Updated in this commit: f1d50b8

derekcollison
derekcollison reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, wondering if we can place nak delay into opts to avoid passing around explicit arg that is usually 0.

@kozlovic
Passed nakDelay as an option to internal ackReply() function
d34c12d 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic
Copy link
Member Author

kozlovic commented Feb 1, 2022

@derekcollison I think I was able to do as you asked: d34c12d

derekcollison
derekcollison approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit b16cefd into main Feb 1, 2022
@kozlovic kozlovic deleted the nak_with_delay_and_backoff branch February 1, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kozlovic @coveralls @derekcollison