Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose nats.Context option for nats.KeyWatcher #904

Merged
merged 3 commits into from Mar 18, 2022

Conversation

matthewdevenny
Copy link
Contributor

Signed-off-by: Matthew DeVenny matt@boxboat.com

Currently if you wish to extend the nats.KeyValue interface, when implementing Watch you have no means to get at the nats.Context option if it has been set on the nats.KeyWatcher. This PR proposes a method to the nats.KeyWatcher to access that context.

@coveralls
Copy link

coveralls commented Feb 10, 2022

Coverage Status

Coverage decreased (-0.03%) to 85.147% when pulling 4a88aa4 on boxboatmatt:feature/kv-interface-options into 3ead809 on nats-io:main.

kv.go Outdated Show resolved Hide resolved
Signed-off-by: Matthew DeVenny <matt@boxboat.com>
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caleblloyd caleblloyd merged commit e0e03e3 into nats-io:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants