[FIXED] KV use of JS prefix #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user creates a JS context with a custom prefix, this needs to be used for the subject of the Put() and Delete() operations. This is addressing the architecture design ADR-19. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
matthiashanel
suggested changes
Feb 15, 2022
matthiashanel
approved these changes
Feb 15, 2022
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@matthiashanel Actually, you were right. Adding the test showed that the update would fail, so we need to use the prefix there too. I added the test for that. |
thomastaylor312
added a commit
to thomastaylor312/nats.rs
that referenced
this pull request
Apr 22, 2022
This is essentially the same fix as nats-io/nats.go#910 in the go client, complete with test to make sure things work
Jarema
pushed a commit
to nats-io/nats.rs
that referenced
this pull request
Apr 25, 2022
This is essentially the same fix as nats-io/nats.go#910 in the go client, complete with test to make sure things work
Jarema
pushed a commit
to nats-io/nats.rs
that referenced
this pull request
Apr 25, 2022
This is essentially the same fix as nats-io/nats.go#910 in the go client, complete with test to make sure things work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user creates a JS context with a custom prefix, this needs
to be used for the subject of the Put() and Delete() operations.
This is addressing the architecture design ADR-19.
Signed-off-by: Ivan Kozlovic ivan@synadia.com