[FIXED] Websocket: discovered urls would not have "wss://" scheme #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user originally connects with "wss://" but has not configured any secure related option (Options.Secure/TLSConfig), then when adding implicit URLs (from the server INFO) the library would add the "ws://" prefix to the received URL. When trying to connect to those URLs, the library would not try to make a TLS handshake and would get an error back that would result in a "websocket invalid connection". Resolves #914 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@ColinSullivan1 @wallyqs PING? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user originally connects with "wss://" but has not configured
any secure related option (Options.Secure/TLSConfig), then when
adding implicit URLs (from the server INFO) the library would add
the "ws://" prefix to the received URL.
When trying to connect to those URLs, the library would not try
to make a TLS handshake and would get an error back that would
result in a "websocket invalid connection".
Resolves #914
Signed-off-by: Ivan Kozlovic ivan@synadia.com