Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Connect error when given an invalid user creds file #916

Merged
merged 1 commit into from Feb 23, 2022

Conversation

kozlovic
Copy link
Member

The failure to connect would be "no nkey seed found". It will now
be more explicit:

error signing nonce: unable to extract key pair from file "myfile.creds": no nkey seed found

Signed-off-by: Ivan Kozlovic ivan@synadia.com

The failure to connect would be "no nkey seed found". It will now
be more explicit:
```
error signing nonce: unable to extract key pair from file "myfile.creds": no nkey seed found
```

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 85.29% when pulling abfa624 on improve_invalid_certs_error into 0096b1b on main.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 268c37b into main Feb 23, 2022
@kozlovic kozlovic deleted the improve_invalid_certs_error branch February 23, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants