Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nats: prefix to stream info errors to match consumer info #928

Merged
merged 1 commit into from Mar 16, 2022
Merged

Add nats: prefix to stream info errors to match consumer info #928

merged 1 commit into from Mar 16, 2022

Conversation

derekcollison
Copy link
Member

Make same as consumer by adding prefix.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Add nats: prefix to stream info errors to match consumer info hand…
241d156 
…ling.

Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
kozlovic approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that we don't have a test that check for error without the 'nats: ' prefix :-)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 85.239% when pulling 241d156 on nats_err_pre into 77460b8 on main.

@derekcollison
Copy link
Member Author

Just in the server from the other day ;)

@derekcollison derekcollison merged commit b54113a into main Mar 16, 2022
@wallyqs wallyqs deleted the nats_err_pre branch March 16, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@derekcollison @coveralls @wallyqs @kozlovic