Allow KV and Obj to specify placement options. #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
approved these changes
Mar 16, 2022
| @@ -347,6 +348,7 @@ func (js *js) CreateKeyValue(cfg *KeyValueConfig) (KeyValue, error) { | |||
| MaxMsgSize: maxMsgSize, | |||
| Storage: cfg.Storage, | |||
| Replicas: replicas, | |||
| Placement: cfg.Placement, | |||
There was a problem hiding this comment.
Question: would a stream info return the same user-provided-placement information provided here, or will the server alter that based on where the stream is placed?
The reason I ask is that for the v2.7.2/discard policy upgrade process done below, we do a reflect.DeepEqual() based on this stream config and the stream config we get from the js.StreamInfo() call.
There was a problem hiding this comment.
If it is specified and the system can not accomodate it will fail.
I am adding in ability to "move" assets though now in server, but that update should be stamped etc so we should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io