Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native time.Time.Equal method for equality check #993

Merged
merged 1 commit into from Jun 7, 2022
Merged

Use native time.Time.Equal method for equality check #993

merged 1 commit into from Jun 7, 2022

Conversation

bruth
Copy link
Member

@bruth bruth commented Jun 7, 2022

Fixes #992

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 83.899% when pulling 5a64802 on bruth:patch-1 into fe748b3 on nats-io:main.

piotrpio
piotrpio approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution!

@derekcollison derekcollison merged commit 8015437 into nats-io:main Jun 7, 2022
@bruth bruth deleted the patch-1 branch June 7, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equality check on consumer time values use pointers
4 participants
@bruth @coveralls @piotrpio @derekcollison