Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TLS connection state when possible #996

Merged
merged 1 commit into from Jun 10, 2022

Conversation

ripienaar
Copy link
Contributor

@ripienaar ripienaar commented Jun 10, 2022

I would like to be able to report things like ciphers,
tls or not, verified or not etc in nats account info
where its shows other connection properties but had
no way to get at this information

Signed-off-by: R.I.Pienaar rip@devco.net

@ripienaar ripienaar changed the title Expose TLS connection state whne possible Expose TLS connection state when possible Jun 10, 2022
I would like to be able to report things like ciphers,
tls or not, verified or not etc in nats account info
where its hows other connection properties but had
no way to get at this information

Signed-off-by: R.I.Pienaar <rip@devco.net>
@coveralls
Copy link

coveralls commented Jun 10, 2022

Coverage Status

Coverage increased (+0.02%) to 83.928% when pulling 36b74da on ripienaar:tls_conn_state into 1a55cb9 on nats-io:main.

nats.go Show resolved Hide resolved
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ripienaar ripienaar merged commit dcbb65a into nats-io:main Jun 10, 2022
@ripienaar ripienaar deleted the tls_conn_state branch June 10, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants