Accept Tls First as an Option #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
reviewed
Oct 18, 2023
| @@ -1465,6 +1475,15 @@ public Builder ignoreDiscoveredServers() { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Set tls first behavior on. Default is off | |||
| * @return the Builder for chaining | |||
There was a problem hiding this comment.
It would be good to expand this comment to mention that the respective settings have to be set in the server itself for this to work. E.g. go client has:
// TLSHandshakeFirst is used to instruct the library perform
// the TLS handshake right after the connect and before receiving
// the INFO protocol from the server. If this option is enabled
// but the server is not configured to perform the TLS handshake
// first, the connection will fail.There was a problem hiding this comment.
updated the api and added notes to the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of server release 2.10.3 TLS Handshake First is an option.