Multiple Filter Subjects and Subject validation changes #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arondi
requested changes
Sep 19, 2023
| @@ -375,14 +375,14 @@ public interface JetStream { | |||
| * <p>See {@link io.nats.client.Connection#createDispatcher(MessageHandler) createDispatcher} for | |||
| * information about creating an asynchronous subscription with callbacks. | |||
| * | |||
| * @param subject the subject to subscribe to | |||
| * @param subscribeSubject the subject to subscribe to | |||
There was a problem hiding this comment.
Document when this can be empty or null
| * Gets the max filter subject of this consumer configuration. | ||
| * @return the filter subject. | ||
| * Gets the first filter subject of this consumer configuration. Will be null if there are none. | ||
| * @return the first filter subject. |
| // 2. figure out user provided subjects and prepare the userCcFilterSubjects | ||
| userSubscribeSubject = emptyAsNull(userSubscribeSubject); | ||
| List<String> userCcFilterSubjects = new ArrayList<>(); | ||
| if (userCC.getFilterSubject() == null) { // empty filterSubjects gives gives null |
| String subj; | ||
| if (consumerCreate290Available) { | ||
| if (consumerCreate290Available && !multipleFilterSubject) { |
There was a problem hiding this comment.
maybe add a code comment for this block
scottf
changed the title
This was referenced Sep 20, 2023
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Support for Multiple Filter Subjects feature in Server 2.10
2. Changes and consistency for Subject validation
3. Changes and consistency for Queue name validation