Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out missing style snippets #1096

Closed
12 of 16 tasks
calculuschild opened this issue Nov 9, 2020 · 7 comments
Closed
12 of 16 tasks

Fill out missing style snippets #1096

calculuschild opened this issue Nov 9, 2020 · 7 comments
Assignees
Labels

Comments

@calculuschild
Copy link
Member

calculuschild commented Nov 9, 2020

Once the new rendering pipeline is in place, we can start inserting more requested code snippets and styling features that users have created or requested for a long time. Part of the reason these have not been added until now, is the over-dependence on random markdown combinations to create textboxes, which leads to lots of conflicting styling issues in the CSS. Further, the use of invalid markdown due to an outdated markdown parser makes these conflicts even more common.

Blocked by #1093. Once that is complete, more of these tasks can be finished out.

This issue will collect the sub-tasks and related issues.

Tasks

Clean up existing styling and snippets

Include snippets for common missing PHB items

(collect from issues, a lot of these are already figured out)

Include snippets for user convenience

(collect from issues)

Correct other existing style bugs

@calculuschild calculuschild added Epic blocked Waiting on a dependency, other feature, etc., first labels Nov 9, 2020
@calculuschild calculuschild added this to Backlog in Issues Organizer via automation Jan 3, 2021
@calculuschild calculuschild moved this from Backlog to To do in Issues Organizer Jan 3, 2021
@calculuschild calculuschild pinned this issue Jan 3, 2021
@Gazook89
Copy link
Collaborator

The "Page Number" snippet contains both a page number component and a 'footer' component, and I think they should be separated....or, the footer component be added to the "Auto Incrementing Page Number" snippet as well...it's weird that the footer is in one, but not the other.

@calculuschild
Copy link
Member Author

I don't mind separating them. That makes sense to me.

@calculuschild
Copy link
Member Author

User u/Kaiburr_Kath-Hound on Reddit (with help from others) has completed several of these and notified me that he would like to contribute them as official snippets. May need slight tweaks but 95% of the work is done:

https://www.reddit.com/r/homebrewery/comments/qubn28/phbstyle_including_title_page_credits_page/

@ericscheid ericscheid removed the blocked Waiting on a dependency, other feature, etc., first label May 12, 2022
@ericscheid
Copy link
Collaborator

No longer blocked by #1093 as on 12 Sep 2021.

@5e-Cleric 5e-Cleric self-assigned this Jan 28, 2023
@5e-Cleric
Copy link
Member

5e-Cleric commented Jan 28, 2023

Cover page done in #2649, approval pending.
I have a working demo of a Back Cover in my local, but i would like a help with the snippet text.
Did this brew a year ago, based on a tiny table at the end of an official book, would this work as a credditing snippet?

@5e-Cleric
Copy link
Member

5e-Cleric commented Jan 30, 2023

Update on this:

Include snippets for common missing PHB items

Merged Done* Name PR Issue
no yes adventure flowchart #2701 * #936
no partially Notes on paper scraps #826
no yes credits page
no no Monster Index TOC (GGR** #p5 )
no yes Timeline #3194

*: related PR
**: Guildmaster's Guide to Ravnica

I consider as Done when i have a working demo.

Most are already done in Kaiburr's Player's Handbook Template
I'll mark them as soon as i have a working demo of them in local, and i'll put a PR for each as soon as i can.

if you want to add a snippet, comment here.

@5e-Cleric
Copy link
Member

Closing, as track of snippets will now be kept in #3236

@calculuschild calculuschild unpinned this issue Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants