Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images with reference link are not displayed inside tables in V3 #2307

Closed
azzco opened this issue Aug 31, 2022 · 2 comments
Closed

Images with reference link are not displayed inside tables in V3 #2307

azzco opened this issue Aug 31, 2022 · 2 comments
Labels
Approved Has been discussed and an approach is agreed upon P2 - minor feature or not urgent Minor bugs or less-popular features solution found A solution exists; just needs to be applied

Comments

@azzco
Copy link

azzco commented Aug 31, 2022

I figured I'd make my document more readable by converting the image links inside a table to references. Inside the table I only got text output but outside it works.

I wrote a small snippet to showcase this, when I noticed that the legacy renderer shows the image as expected.

Share Link : https://homebrewery.naturalcrit.com/share/YBhE6rZA3zM8

Brew code to reproduce :

Click to expand

Reference style linked image

Normal

Monster{float:right}Adding images with reference style links works as expected in normal text.
:
As evident by this little guy here: ➜
:::

Table

It does not appear to work inside tables.

Reference link Full link
Monster Monster

@calculuschild
Copy link
Member

calculuschild commented Aug 31, 2022

Thanks for the report!

I think I know what's causing this. V4 of Marked.js broke reflink inside of tables and only just fixed that in v4.0.16. markedjs/marked#2471

Our custom Tables extension for column and row spanning was based on the older Marked code, so I probably just need to make the same fix to our extension. Shouldn't be too hard.

@calculuschild calculuschild added solution found A solution exists; just needs to be applied P2 - minor feature or not urgent Minor bugs or less-popular features Approved Has been discussed and an approach is agreed upon labels Aug 31, 2022
@calculuschild
Copy link
Member

Fixed in V3.2.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Has been discussed and an approach is agreed upon P2 - minor feature or not urgent Minor bugs or less-popular features solution found A solution exists; just needs to be applied
Projects
None yet
Development

No branches or pull requests

2 participants