Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Renovate dashboard approval for major taggit updates #1960

Closed
HonkingGoose opened this issue Jun 27, 2022 · 0 comments · Fixed by #1977
Closed

Require Renovate dashboard approval for major taggit updates #1960

HonkingGoose opened this issue Jun 27, 2022 · 0 comments · Fixed by #1977
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@HonkingGoose
Copy link

Background

Follow up from #1896 (comment).

https://docs.renovatebot.com/configuration-options/#dependencydashboardapproval Would it be better to instead configure?

{
  "major": {
    "dependencyDashboardApproval": true
  }
}

Is there an instance of the "dependency dashboard" in one of our other repos that I can see as an example?

That setting would require manually triggering a PR for every major dependency update which may often not be an issue. As said above that would only hold back the taggit update because it was the only one to cause issues on a major release boundary.

Proposed Changes

Use packageRules to tell Renovate what to do for a specific package.

If you want Renovate to wait for approval before raising a major taggit update, put this in your renovate.json file:

{
  "packageRules": [
    {
      "description": "Require dashboard approval for major updates for taggit",
      "matchPackageNames": ["taggit"],
      "matchUpdateTypes": ["major"],
      "dependencyDashboardApproval": true
    }
  ]
}

Renovate docs

Justification

Reduce developer busy-work. 😄

@bryanculver bryanculver self-assigned this Jun 28, 2022
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Jun 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants