Skip to content
This repository has been archived by the owner on Jan 13, 2020. It is now read-only.

Can't run it natively (using nativefier) #54

Open
oquirozm opened this issue Dec 17, 2018 · 3 comments
Open

Can't run it natively (using nativefier) #54

oquirozm opened this issue Dec 17, 2018 · 3 comments

Comments

@oquirozm
Copy link

Hi! Awesome app. I tried creating an electron version using nativefier but every time the app tries to make a request it opens the request's url in my browser. Is there anything I can do to prevent that? Is there anything that can be done to prevent it? It makes it unusable as a native electron app.

@alx242
Copy link

alx242 commented Dec 18, 2018

This is because nativefier will automatically try and open any external-urls outside the electron-app. To force it to consider the url as "internal" this has to be specified on the command line.

example:
nativefier --name "Play Apple Music" --internal-urls ".(itunes.apple.com)."

But this will still fail due to getting a 405 (method not allowed) from the authenticateMusicKitRequest :/

@oquirozm
Copy link
Author

@alx242 I haven't checked the MusicKit documentation so correct me if I'm wrong but isn't the use of external-urls to perform actions inside the app a consequence of using Angular? Would using different tools (e.g. React) help solve the issue?

@naveedgol
Copy link
Owner

I tried to run it as an Electron app as well and ran into blank auth popups. This is the same issue described in #17. Given that MusicKit handles all new tab behavior, this is beyond my control.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants