Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in getRotation() #42

Open
out0 opened this issue Jun 14, 2019 · 4 comments
Open

bug in getRotation() #42

out0 opened this issue Jun 14, 2019 · 4 comments

Comments

@out0
Copy link

out0 commented Jun 14, 2019 •
edited

Your getRotation() is always returning 0, when it should call super to return view's getRotation or just be deleted.

This bug prevent your view from correctly calculate rotation, therefore no rotation back to 0 degrees is possible.

just remove getRotation() override and things should go back to normal I guess
@helloyako
Copy link
Contributor

I don't think so.
This library doesn't provide rotation feature.

@isabsent
Copy link

Nice lib, thanks!
Are you planning to support rotation?

@helloyako
Copy link
Contributor

@isabsent
Thank you.
I don't have plan to support rotation now.
But I think it's good idea if this lib support rotation.
I will consider that.

@jackyhieu1211-hn
Copy link

jackyhieu1211-hn commented May 12, 2020 •
edited

Refer: #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@isabsent @helloyako @jackyhieu1211-hn @out0