Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I want fields to be injected with a Kotlin Duration type #962

Open
this-is-spear opened this issue Mar 24, 2024 · 2 comments
Open

I want fields to be injected with a Kotlin Duration type #962

this-is-spear opened this issue Mar 24, 2024 · 2 comments
Assignees
@this-is-spear
Labels
enhancement New feature or request
Milestone
1.0.16

Comments

@this-is-spear
Copy link
Contributor

Describe the feature you request

The user doesn't understand why the field needs to be injected with the Long type.

sut.giveMeBuilder<DurationValue>()
    .set(DurationValue::duration, Long.MAX_VALUE)
    .sample()

Suggest A Solution

For ease of use, Duration needs to be modified to allow you to inject Duration values.

sut.giveMeBuilder<DurationValue>()
    .set(DurationValue::duration, Duration.INFINITE)
    .sample()

If the feature request is approved, would you be willing to submit a PR?

Yes
@this-is-spear this-is-spear added the enhancement New feature or request label Mar 24, 2024
@seongahjo
Copy link
Contributor

@this-is-spear
Sounds great. Could you make a PR for it?

@seongahjo seongahjo added this to the 1.0.15 milestone Mar 26, 2024
@this-is-spear
Copy link
Contributor Author

Okay, good!

@seongahjo seongahjo modified the milestones: 1.0.15, 1.0.16 Mar 28, 2024
@this-is-spear this-is-spear mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@this-is-spear this-is-spear

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.16
Development

No branches or pull requests
2 participants
@seongahjo @this-is-spear