Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in constructor for OAuth2Config after 2.1.3 #680

Open
tronghn opened this issue May 13, 2024 · 0 comments
Open

Breaking change in constructor for OAuth2Config after 2.1.3 #680

tronghn opened this issue May 13, 2024 · 0 comments

Comments

@tronghn
Copy link
Contributor

tronghn commented May 13, 2024

From @jan-olaveide:

#645 added the ability to rotate refresh tokens together with a new parameter for the OAuth2Config class.

This breaks for consuming code that doesn't explicitly define parameter names during construction, e.g. https://github.com/navikt/token-support/blob/master/token-validation-spring-test/src/main/kotlin/no/nav/security/token/support/spring/test/MockOAuth2ServerAutoConfiguration.kt

Ideally, new parameters with default values could be added to the end of the constructor to prevent such breakage. Otherwise this could have warranted a minor version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant