Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test on windows since v5.0.0 #131

Open
mojoaxel opened this issue Dec 28, 2023 · 0 comments
Open

Failing test on windows since v5.0.0 #131

mojoaxel opened this issue Dec 28, 2023 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mojoaxel
Copy link
Collaborator

Since the 5.0.0 release the test don't nun anymore on windows:

(node:12860) ExperimentalWarning: VM Modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

FAIL test/fixtures.test.js
  ● PDFMerger › merge two simple files

    Path contains invalid characters: \C:\Users\xxxxxxxx\pdf-merger-js\test\tmp

      15 | describe('PDFMerger', () => {
      16 |   beforeAll(async () => {
    > 17 |     await fs.ensureDir(TMP_DIR)
         |              ^
      18 |   })
      19 |
      20 |   test('merge two simple files', async () => {

      at checkPath (node_modules/fs-extra/lib/mkdirs/utils.js:16:21)
      at Object.<anonymous>.module.exports.makeDir (node_modules/fs-extra/lib/mkdirs/make-dir.js:12:3)
      at Object.defineProperty.value (node_modules/universalify/index.js:21:45)
      at Object.ensureDir (test/fixtures.test.js:17:14)

I see two problems here:

  1. The VM Modules is an experimental feature warning comes from the --experimental-vm-modules parameter, that is needed to support ESM modules in jest, wich is still experimental: https://jestjs.io/docs/ecmascript-modules
  2. The invalid path is propably caused by the \C:.
@mojoaxel mojoaxel added bug Something isn't working help wanted Extra attention is needed labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant