Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deb package configurable through /etc/default #114

Open
itsx opened this issue Aug 19, 2019 · 1 comment · May be fixed by #116
Open

Make deb package configurable through /etc/default #114

itsx opened this issue Aug 19, 2019 · 1 comment · May be fixed by #116

Comments

@itsx
Copy link
Contributor

itsx commented Aug 19, 2019

Problem:
I believe that a standard way to configure debian packages is through files in the
/etc/default directory (the same way is used in prometheus node_exporter for example: https://github.com/prometheus/node_exporter). This configuration will survive also package upgrade.

Link to question about /etc/default:
https://askubuntu.com/questions/429592/what-is-the-purpose-of-etc-default

Now when I install process-exporter_0.5.0_linux_amd64.deb package, I have to add starting parameters (as -threads=false) directly into a service file (/lib/systemd/system/process-exporter.service), which will be rewritten during package upgrade and is not a recommended practice.

Question:
Is there any reason to make deb package without /etc/default configuration?

@tlinhart tlinhart linked a pull request Aug 19, 2019 that will close this issue
@rhamon
Copy link

rhamon commented Oct 1, 2019

Overrides to the service should go to /etc/systemd/system/process-exporter.service and this will survive package upgrades. You override could also make use of an environment file in /etc/default/process-exporter.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants