Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove process group when namedprocess_namegroup_num_procs = 0 #282

Open
zviRosenfeldRedis opened this issue Nov 14, 2023 · 4 comments · May be fixed by #283
Open

Remove process group when namedprocess_namegroup_num_procs = 0 #282

zviRosenfeldRedis opened this issue Nov 14, 2023 · 4 comments · May be fixed by #283

Comments

@zviRosenfeldRedis
Copy link

I'm tracking processes that die after a while, and are never expected to come back. So I don't want these process groups to appear in the stats once the process dies. But in practice I continue seeing it (and namedprocess_namegroup_num_procs for it is 0). It only disappears when I restart process-exporter.
Is there a way I can cause the process group to disappear when namedprocess_namegroup_num_procs for it is 0?
@zviRosenfeldRedis zviRosenfeldRedis linked a pull request Nov 20, 2023 that will close this issue
Open
@zviRosenfeldRedis
Copy link
Author

Update: I merged a fix for this into a fork: https://github.com/RedisLabs/process-exporter. I added a flag remove-empty-groups, and if that flag is true we forget any group with no processes (default is false).

I also opened a PR back upstream to with my fix, but seeing how this repository wasn't updated since 2021, I doubt it's ever getting it...

@Alex-wwei
Copy link

It seems to have been removed, but as time went on, the exporter's memory footprint increased.

@zviRosenfeldRedis
Copy link
Author

I pushed a fix into the repository that probably fixed the issue. (into this repository: https://github.com/RedisLabs/process-exporter).
@Alex-wwei, can you confirm if the bug was indeed fixed?

@Alex-wwei
Copy link

I pushed a fix into the repository that probably fixed the issue. (into this repository: https://github.com/RedisLabs/process-exporter). @Alex-wwei, can you confirm if the bug was indeed fixed?

@zviRosenfeldRedis It`s much better now, But there may still be a slight increase in memory due to the constant changes in the process。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added remove-empty-groups option zviRosenfeldRedis/process-exporter
2 participants
@Alex-wwei @zviRosenfeldRedis