Here batchGeocoding using the Here Batch API #329
Merged
+201
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charly22
commented
Feb 8, 2022
| 'user-agent': | ||
| 'Mozilla/5.0 (X11; Linux i586; rv:31.0) Gecko/20100101 Firefox/31.0' | ||
| 'user-agent': 'Mozilla/5.0 (X11; Linux i586; rv:31.0) Gecko/20100101 Firefox/31.0', | ||
| 'accept': 'application/json;q=0.9, */*;q=0.1' |
There was a problem hiding this comment.
Not sure about this, since will affect other providers but I didn't find a way to specify this header from HereGeocoder on the adapter without breaking its API, but if you don't, all responses from Here Batch API will be in XML.
Thoughts?
There was a problem hiding this comment.
I think it should work I started to add some integration test so we can verify that it do not break every provider.
|
@nchaulet Thanks for letting us send all these patches! Please, anything you see might be improved please let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_batchGeocodeonHereGeocoderto use the Here Batch API