Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(JS-0057) Found empty functions #488

Open
robotichead opened this issue Oct 2, 2023 · 2 comments
Open

(JS-0057) Found empty functions #488

robotichead opened this issue Oct 2, 2023 · 2 comments
Assignees
@robotichead

Comments

@robotichead
Copy link
Collaborator

Description

Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.

Occurrences

There are 150 occurrences of this issue in the repository.

See all occurrences on DeepSource → app.deepsource.com/gh/robotichead/NearBeach/issue/JS-0057/occurrences/
@robotichead robotichead self-assigned this Oct 2, 2023
@DHRUVKHANDELWAL00
Copy link

hey @robotichead , i would like to work on it. please assign me

@robotichead
Copy link
Collaborator Author

This issue requires placing in the ErrorModalMixin, as that will handle what to do when an error occurs. We can't remove these functions - just finally populate them with instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robotichead robotichead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robotichead @DHRUVKHANDELWAL00