Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make includeStandardDefines configurable #383

Open
micheljung opened this issue Sep 28, 2020 · 0 comments
Open

Make includeStandardDefines configurable #383

micheljung opened this issue Sep 28, 2020 · 0 comments

Comments

@micheljung
Copy link

If I understood #264 correctly, it was always generated before and now it's only if there is actually e.g. a postInstall script defined.

In our case, scripts like postInstall need to be approved by QA. Once the script changes, it needs to be approved again. Since RPM_PACKAGE_RELEASE and RPM_PACKAGE_VERSION change with every build, this is obviously bad.

If includeStandardDefines was configurable, this would be easy to solve:

result = includeStandardDefines ?
String.format(" RPM_ARCH=%s \n RPM_OS=%s \n RPM_PACKAGE_NAME=%s \n RPM_PACKAGE_VERSION=%s \n RPM_PACKAGE_RELEASE=%s \n\n",
task.getArchString(),
task.os?.toString()?.toLowerCase() ?: '',
task.getPackageName(),
task.getVersion(),
task.getRelease()) : null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant