Skip to content

Commit

Permalink
fix function name in comment (#2240)
Browse files Browse the repository at this point in the history
Signed-off-by: thirdkeyword <fliterdashen@gmail.com>
  • Loading branch information
thirdkeyword committed Mar 6, 2024
1 parent 75e4ad9 commit 352ad41
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pkg/model/workflow.go
Expand Up @@ -343,7 +343,7 @@ func environment(yml yaml.Node) map[string]string {
return env
}

// Environments returns string-based key=value map for a job
// Environment returns string-based key=value map for a job
func (j *Job) Environment() map[string]string {
return environment(j.Env)
}
Expand Down Expand Up @@ -578,7 +578,7 @@ func (s *Step) String() string {
return s.ID
}

// Environments returns string-based key=value map for a step
// Environment returns string-based key=value map for a step
func (s *Step) Environment() map[string]string {
return environment(s.Env)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/runner/expression.go
Expand Up @@ -106,7 +106,7 @@ func (rc *RunContext) NewExpressionEvaluatorWithEnv(ctx context.Context, env map
//go:embed hashfiles/index.js
var hashfiles string

// NewExpressionEvaluator creates a new evaluator
// NewStepExpressionEvaluator creates a new evaluator
func (rc *RunContext) NewStepExpressionEvaluator(ctx context.Context, step step) ExpressionEvaluator {
// todo: cleanup EvaluationEnvironment creation
job := rc.Run.Job()
Expand Down
2 changes: 1 addition & 1 deletion pkg/runner/logger.go
Expand Up @@ -52,7 +52,7 @@ func Masks(ctx context.Context) *[]string {
return &[]string{}
}

// WithLogger adds a value to the context for the logger
// WithMasks adds a value to the context for the logger
func WithMasks(ctx context.Context, masks *[]string) context.Context {
return context.WithValue(ctx, masksContextKeyVal, masks)
}
Expand Down

0 comments on commit 352ad41

Please sign in to comment.