From 352ad41ad2b8a205b12442859280b0e938b7e4ab Mon Sep 17 00:00:00 2001 From: huajin tong <137764712+thirdkeyword@users.noreply.github.com> Date: Wed, 6 Mar 2024 22:20:06 +0800 Subject: [PATCH] fix function name in comment (#2240) Signed-off-by: thirdkeyword --- pkg/model/workflow.go | 4 ++-- pkg/runner/expression.go | 2 +- pkg/runner/logger.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/model/workflow.go b/pkg/model/workflow.go index 118645405bd..7fbecd6c537 100644 --- a/pkg/model/workflow.go +++ b/pkg/model/workflow.go @@ -343,7 +343,7 @@ func environment(yml yaml.Node) map[string]string { return env } -// Environments returns string-based key=value map for a job +// Environment returns string-based key=value map for a job func (j *Job) Environment() map[string]string { return environment(j.Env) } @@ -578,7 +578,7 @@ func (s *Step) String() string { return s.ID } -// Environments returns string-based key=value map for a step +// Environment returns string-based key=value map for a step func (s *Step) Environment() map[string]string { return environment(s.Env) } diff --git a/pkg/runner/expression.go b/pkg/runner/expression.go index 412d1c027ce..2e3152b0993 100644 --- a/pkg/runner/expression.go +++ b/pkg/runner/expression.go @@ -106,7 +106,7 @@ func (rc *RunContext) NewExpressionEvaluatorWithEnv(ctx context.Context, env map //go:embed hashfiles/index.js var hashfiles string -// NewExpressionEvaluator creates a new evaluator +// NewStepExpressionEvaluator creates a new evaluator func (rc *RunContext) NewStepExpressionEvaluator(ctx context.Context, step step) ExpressionEvaluator { // todo: cleanup EvaluationEnvironment creation job := rc.Run.Job() diff --git a/pkg/runner/logger.go b/pkg/runner/logger.go index 5a98210b3c3..a788f680e3a 100644 --- a/pkg/runner/logger.go +++ b/pkg/runner/logger.go @@ -52,7 +52,7 @@ func Masks(ctx context.Context) *[]string { return &[]string{} } -// WithLogger adds a value to the context for the logger +// WithMasks adds a value to the context for the logger func WithMasks(ctx context.Context, masks *[]string) context.Context { return context.WithValue(ctx, masksContextKeyVal, masks) }