fix github.action_ref / github.job (composite action) #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherHX
commented
Sep 22, 2023
| @@ -53,11 +56,11 @@ func newCompositeRunContext(ctx context.Context, parent *RunContext, step action | |||
| Name: parent.Name, | |||
| JobName: parent.JobName, | |||
| Run: &model.Run{ | |||
| JobID: "composite-job", | |||
| JobID: parent.Run.JobID, | |||
There was a problem hiding this comment.
github.job will use that value, composite-job is wrong in all cases
ChristopherHX
commented
Sep 22, 2023
Comment on lines
+41
to
+42
| env["GITHUB_ACTION_REPOSITORY"] = gh.ActionRepository | ||
| env["GITHUB_ACTION_REF"] = gh.ActionRef |
There was a problem hiding this comment.
That's the fastest fix I can imagine, everything else blows up my head
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## master #2020 +/- ##
==========================================
+ Coverage 61.22% 61.74% +0.51%
==========================================
Files 46 52 +6
Lines 7141 8550 +1409
==========================================
+ Hits 4372 5279 +907
- Misses 2462 2848 +386
- Partials 307 423 +116
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cplee
approved these changes
Oct 3, 2023
jmikedupont2
pushed a commit
to meta-introspector/act
that referenced
this pull request
Mar 10, 2024
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm burning my fingers by touching this. The test avoid future regression, since it has never been covered by tests in the past.
I know that GITHUB_ACTION_REPOSITORY and GITHUB_ACTION_REF are not defined for composite actions like
INPUT_<name>, but not everyone wanted to archive 100% compatibilityFixes #2019