Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ping to improve network test #2266

Merged
merged 1 commit into from Mar 28, 2024
Merged

Conversation

wolfogre
Copy link
Member

The ping command works well with mDNS, while the host command does not.

To avoid failed tests like:

2024-03-28T07:30:14.5399002Z [test network setup/test] [DEBUG] Working directory '/home/runner/work/act/act/pkg/runner/testdata'
2024-03-28T07:30:14.5399461Z [test network setup/test]   | fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net
2024-03-28T07:30:14.5400024Z [test network setup/test]   | fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net has address 10.1.0.90
2024-03-28T07:30:14.5400617Z [test network setup/test]   | Host fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net not found: 3(NXDOMAIN)
2024-03-28T07:30:14.5400892Z [test network setup/test]   ❌  Failure - Main Run hostname test
2024-03-28T07:30:14.5401089Z [test network setup/test] exitcode '1': failure
2024-03-28T07:30:14.5401260Z [test network setup/test] 🏁  Job failed

@wolfogre wolfogre added the kind/bug Something isn't working label Mar 28, 2024
@wolfogre wolfogre requested a review from a team as a code owner March 28, 2024 08:17
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.20%. Comparing base (5a80a04) to head (a1392f1).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2266      +/-   ##
==========================================
+ Coverage   61.56%   62.20%   +0.64%     
==========================================
  Files          53       56       +3     
  Lines        9002     9139     +137     
==========================================
+ Hits         5542     5685     +143     
+ Misses       3020     3006      -14     
- Partials      440      448       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's see how much better it will be

@mergify mergify bot merged commit f56dd65 into nektos:master Mar 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants