Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload In Sandbox Broken #501

Closed
jonmchan opened this issue Aug 29, 2014 · 23 comments
Closed

File Upload In Sandbox Broken #501

jonmchan opened this issue Aug 29, 2014 · 23 comments
Labels

Comments

@jonmchan
Copy link
Contributor

The File Upload functionality is broken - it is submitting garbage data in the REQUEST body. Something broke between my branch and getting it into master... I suspect it is all the swagger additions. I did check my branch and it still works, so it isn't the original code. When I have a chance, I will debug this.

@willdurand willdurand added the bug label Oct 8, 2014
@jonmchan
Copy link
Contributor Author

I finally had a chance to come back to this bug - this is caused by the fix in #453 / #457. The issue is that the data it being sent as multipart/form-data but the headers are overriding Content-type to be application/x-www-form-urlencoded. I agree we shouldn't delete all the custom headers, but the Content-type header definitely needs to be overriden for file upload to work.

@UFOMelkor
Copy link

Any news on this? File upload is still broken. #535 fixes this for me but has been closed. If you tell me what was wrong with #535 I would be happy to create a pull request.

@Wirone
Copy link

Wirone commented Jun 9, 2015

I've spent at least 1 hour on my API developing, testing and vituperating "wtf why my files can't be seen in controller's action?".. Then I checked headers.

First I was thinking it is something about FOSRestBundle, it took me a while to get here. Would be great if it was fixed.

@jonmchan
Copy link
Contributor Author

I fixed this last year - but I don't know why it wasn't merged. The fix is very trivial - delete passing any Content-type and allow the browser JS engine take care of it. @Wirone , if you'd like it to work now, you can look at my PR #535 .

@ch4r1y
Copy link

ch4r1y commented Jul 15, 2015

+1

@AlmogBaku
Copy link
Contributor

Is there any progress on this issue? @willdurand

@hidabe
Copy link

hidabe commented Sep 2, 2015

What about it? @willdurand

@hidabe
Copy link

hidabe commented Sep 2, 2015

@s1yamuza
Copy link

s1yamuza commented Sep 2, 2015

Same problem here...

@brice
Copy link

brice commented Sep 16, 2015

Same problem here

@mremi
Copy link

mremi commented Oct 15, 2015

+1 Any news about this please?

@guillermogfer
Copy link

I also came across with this issue too...

@willdurand
Copy link
Collaborator

Does this fix work?

@willdurand
Copy link
Collaborator

ping @mremi @guillermogfer @brice @s1yamuza

@brice
Copy link

brice commented Oct 27, 2015

Works for me.

@mremi
Copy link

mremi commented Oct 27, 2015

👍 @willdurand

@mremi
Copy link

mremi commented Oct 27, 2015

@willdurand When do you plan to bump a new release? Thx

@willdurand
Copy link
Collaborator

@mremi here you go: 2.10.2

@mremi
Copy link

mremi commented Oct 27, 2015

Nice!

@UFOMelkor
Copy link

Thank you!

@ghanbari
Copy link

thank you

@jonmchan
Copy link
Contributor Author

wow, that took forever. 😄 Glad my PR finally made it in after a whole year!

@guillermogfer
Copy link

Nice job ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.