Required form fields for PUT method always false?

[Jaap-van-Hengstum]

Is there a reason why for the PUT request the required form fields are always false, while for the POST / PATCH methods they reflect what is specified in the form class?

If this has to do with the idempotence of the PUT method, my inclination was to do it the other way round (POST/PATCH does not require all the form fields while PUT does)...

PUT request:

POST / PATCH requests:

[nakashu]

bump ..
Noticed this also. Can someone please explain the reasoning, or link to a resource explaining it.
If the main reason for it is possibility to do partial update with PUT, should then also PATCH have all fields optional ?

[willdurand]

Well, PUT should not be all set to false, and PATCH should get a diff, not single values.

[nakashu]

Sorry. am confused from the answer. Are saying that it is a bug then ?
That PUT documentation should respect definitions?

[michaelpopok]

Up the original question.

In this article @willdurand has stated:

Updating a resource in REST means replacing it actually, especially if you use the PUT HTTP verb.

So as I understand all fields for an entity should be required in case of PUT action (can be exceptions in some cases). Anyway I believe that this check should be removed in Extractor:

if ('PUT' === $annotation->getMethod()) {
    // All parameters are optional with PUT (update)
    array_walk($parameters, function ($val, $key) use (&$parameters) {
        $parameters[$key]['required'] = false;
    });
}

[judgedim]

@michaelpopok I suggest you provide PR :)

[hgiesenow]

I think someone mixed up PUT with PATCH.
For PATCH it makes sense, that there are no required field, as the resource must already exists and there is afaik no way to clear a filled field.

[tristanlins]

Is there a chance to merge the fix kuborgh@72ab9b9 from @kuborgh-hgiesenow ?
I'm still confused of this issue :-D

[willdurand]

Can someone open a Pull Request for that?

[hgiesenow]

The codebase (especially tests) have changed too much since 2.10.0, so it's not mergable anymore. I had no time to look at it again.
@tristanlins feel free to open a new PR (based on mine if you wish to)