ensure that boolean fields are submited as boolean values when using json #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willdurand @Seldaek is it possible to add @lsmith77 as a contributor please ? ☺ LGTM at first sight but i don't really know this part of the code. |
|
I am just not much of a javascript coder also it does like a very hacky direct approach to fix this (like I didn't even try to address XML). |
|
Added as collaborator. I haven't touched or used this bundle in years so I don't think my opinion matters much here :p |
|
@Seldaek thanks :) 3.0 is in progress so imo it's ok to merge something a bit hacky if it works fine, we won't have maintainabily issues anyway. |
|
and I guess the test setup is also known as broken atm? |
|
Yes they are since a patch release if I remember well, I need to take some time to fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.